feat: Oauth design (#269) #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: oauth feature * feat: auth feature * refactor the interface * feat: Oauth implementation * feat: remove no auth client * feat: Add test cases * chore: address review comments * chore: address review comments * feat: Add docs * feat: Add docs * chore: address review comments * feat: addressed review comments * feat: addressed review comments * feat: addressed review comments * feat: addressed review comments * feat: added public oauth examples --------- Co-authored-by: kburke <[email protected]>
manisha1997
force-pushed
the
oauth
branch
4 times, most recently
from
dae1096 to
f060659
Compare
oauth.go
Outdated
| return true, err | ||
| } | ||
|
|
||
| expirationTime := time.Unix(int64(exp), 0).UTC() |
There was a problem hiding this comment.
I think we need to be careful here and probably need some tests.
I believe what this will do if you have a non-Unix time, is create a local timestamp, and then convert it to UTC.
What we want to do is parse the timestamp in the UTC time zone.
We should add some time zone related test cases.
There was a problem hiding this comment.
I'm not sure the above comment is correct on a closer reading but I'd prefer if we had test cases
There was a problem hiding this comment.
sure, I will add them.
tiwarishubham635
requested changes
Apr 3, 2025
tiwarishubham635
requested changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
This PR adds Oauth to twilio-go.
Changes added:
a. The IamService Object used --> This will act as an interface for any IAM service we plan to access
b. The Credentials details
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.