Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches our path-based tests from
test_generator
's compile-time generation to runtime generation usinglibtest_mimic
.This has a couple of benefits:
cargo test; echo '{' > cli/tests/snapshot/inputs/pretty/asdf.ncl; cargo test
the second test succeeds because the new snapshot doesn't get picked upIt also has a couple of downsides:
#[test]
-annotated tests.cargo nextest
, or just living with messy test output.While making these changes, I discovered some core integration tests that weren't actually being run, so I moved them to a place where they'd be picked up automatically.