Add censor function to Capability.Writer
#94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a useful function, present in the corresponding mtl library, that can be defined in terms of the existing `pass` primitive. However, doing so is nontrivial (I spent quite a while banging my head against proxies, ScopedTypeVariables, AllowAmbiguousTypes, and the like) so it seems it would make sense to provide it directly from the library. However, if there's some reason this function can't or shouldn't be provided I'd be happy to be enlightened.
aspiwack
approved these changes
Jun 18, 2021
|
Mmm… we still have a buildkite CI on this. I'll merge later today. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a useful function, present in the corresponding mtl library,
that can be defined in terms of the existing
passprimitive.However, doing so is nontrivial (I spent quite a while banging my head
against proxies, ScopedTypeVariables, AllowAmbiguousTypes, and the
like) so it seems it would make sense to provide it directly
from the library. However, if there's some reason this function can't
or shouldn't be provided I'd be happy to be enlightened.