Skip to content
This repository was archived by the owner on Nov 24, 2022. It is now read-only.

[WIP] Use BigInt for I64 FFI #719

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

gkaracha
Copy link
Member

Work in progress. When finished, this should resolve #718 (and also fix #557).

@gkaracha
Copy link
Member Author

@TerrorJack surprisingly (to me) running test primitive with this PR currently hangs:

$ stack test asterius:primitive
asterius> test (suite: primitive)

[INFO] Compiling test/primitive/primitive.hs to WebAssembly
[INFO] Converting linked IR to binaryen IR
[INFO] Running binaryen optimization
[INFO] Validating binaryen IR
[INFO] Writing WebAssembly binary to "test/primitive/primitive.wasm"
[INFO] Writing JavaScript runtime modules to "test/primitive"
[INFO] Writing JavaScript loader module to "test/primitive/primitive.wasm.mjs"
[INFO] Writing JavaScript req module to "test/primitive/primitive.req.mjs"
[INFO] Writing JavaScript entry module to "test/primitive/primitive.mjs"
[INFO] Running test/primitive/primitive.mjs

Could you test whether you can reproduce this behavior locally too?

@gkaracha gkaracha force-pushed the gkaracha/wip-bigint-i64 branch from bbe98a0 to f0573c0 Compare August 11, 2020 12:18
@gkaracha gkaracha self-assigned this Aug 11, 2020
@gkaracha gkaracha force-pushed the gkaracha/wip-bigint-i64 branch from f0573c0 to 6333ea8 Compare August 11, 2020 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use BigInt for i64 FFI and remove existing i64/f64 casting tricks Conversion from 64-bit Number to BigInt is lossy
1 participant