fix(modal): prevent focus on modal container with negative tabindex #41607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes twbs#41606 - Extra focus stop on hidden element at end of modal When a modal has no focusable children, the FocusTrap was focusing the modal container element (which has tabindex="-1"). This created an unwanted focus stop for keyboard users navigating with Tab. The fix prevents focusing elements with negative tabindex values, which are not meant to be part of the normal tab sequence. - Modified FocusTrap._handleFocusin to check tabIndex >= 0 before focusing trap element - Updated test to expect the new behavior (no focus on negative tabindex elements)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41606 - Extra focus stop on hidden element at end of modal
When a modal has no focusable children, the FocusTrap was focusing the modal container element (which has tabindex="-1"). This created an unwanted focus stop for keyboard users navigating with Tab.
The fix prevents focusing elements with negative tabindex values, which are not meant to be part of the normal tab sequence.
Description
Motivation & Context
Type of changes
Checklist
npm run lint)Live previews
Related issues