Fix: Popover with hover and click triggers closes on mouseleave #41511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a popover is configured with `trigger: 'hover click'`, if you open it by a click, it would incorrectly close when the mouse pointer leaves the trigger element. This was because the `mouseleave` event (part of the hover trigger) would hide the popover without adequately respecting the click trigger's intent to keep it open. This commit modifies the click event listener within `Tooltip.js` (which Popover extends) to explicitly manage the `_activeTrigger[TRIGGER_CLICK]` state: - When a click opens the popover or makes a hover-opened popover sticky, `_activeTrigger[TRIGGER_CLICK]` is set to `true`. - When a click closes an already click-activated popover, `_activeTrigger[TRIGGER_CLICK]` is set to `false`. The `_leave()` method, called by `mouseleave`, already checks `_isWithActiveTrigger()`. With `_activeTrigger[TRIGGER_CLICK]` now accurately reflecting the click state, `_leave()` will not hide a click-activated popover when the mouse leaves the trigger element. The popover will now correctly remain open until a subsequent click closes it.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@amitrathiesh Can you remove the test file here? I think I've confirmed this fixes the issue, but we don't want that new root file to be added. Thanks! |
There was a problem hiding this comment.
Thanks for the PR @amitrathiesh 🙏
Reviewing code changes in tooltip.js and popover.js is always a bit tricky. This may not be the ideal approach, but it’s the one I chose to help move things forward—it's debatable, but necessary given the limited test coverage at the moment.
My focus here isn’t on validating whether the behavior is the "correct" or intended one, but rather on ensuring there are no regressions.
To do this, I compared the Popover and Tooltip components from this branch against those in version v5.3.3.
Popover
| Use case | v5.3.3 | This branch |
|---|---|---|
| Bootstrap documentation | 🟢 | 🟢 |
| CodePen from #40802 | 🟢 | 🟢 |
trigger: 'click' |
🟢 | 🟢 |
trigger: 'hover' |
🟢 | 🟢 |
trigger: 'focus' |
🟢 | 🟢 |
trigger: 'click hover' |
🟢 | 🟢 |
trigger: 'click focus' |
🟢 | 🟢 |
trigger: 'hover focus' |
🟢 | 🟢 |
trigger: 'click hover focus' |
🟢 | 🟢 |
Tooltip
| Use case | v5.3.3 | This branch |
|---|---|---|
| Bootstrap documentation | 🟢 | 🟢 |
trigger: 'click' |
🟢 | 🟢 |
trigger: 'hover' |
🟢 | 🟢 |
trigger: 'focus' |
🟢 | 🟢 |
trigger: 'click hover' |
🟢 | 🟢 |
trigger: 'click focus' |
🟢 | 🟢 |
trigger: 'hover focus' |
🟢 | 🟢 |
trigger: 'click hover focus' |
🟢 | 🟢 |
If anyone has additional tests in mind, please don’t hesitate to share them. 🙏
|
After the review, I've:
|
julien-deramond
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a popover is configured with
trigger: 'hover click', if you open it by a click, it would incorrectly close when the mouse pointer leaves the trigger element. This was because themouseleaveevent (part of the hover trigger) would hide the popover without adequately respecting the click trigger's intent to keep it open.This commit modifies the click event listener within
Tooltip.js(which Popover extends) to explicitly manage the_activeTrigger[TRIGGER_CLICK]state:_activeTrigger[TRIGGER_CLICK]is set totrue._activeTrigger[TRIGGER_CLICK]is set tofalse.The
_leave()method, called bymouseleave, already checks_isWithActiveTrigger(). With_activeTrigger[TRIGGER_CLICK]now accurately reflecting the click state,_leave()will not hide a click-activated popover when the mouse leaves the trigger element. The popover will now correctly remain open until a subsequent click closes it.Description
Motivation & Context
Type of changes
Checklist
npm run lint)Live previews
Related issues
Closes #41379