Skip to content

List-group: Make .list-group-item-action style more specific than .list-group-item. #39064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Aug 16, 2023

Description

Reintroduce #35759 changes by reverting #36018.
Changed the CSS to guard rail the .active style to be overridden on the different states.

Motivation & Context

List-group items with actions are never using their color.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #39047.

@mdo mdo added this to v5.3.4 Apr 3, 2025
@github-project-automation github-project-automation bot moved this to To do in v5.3.4 Apr 3, 2025
@mdo
Copy link
Member

mdo commented Apr 3, 2025

Seems fine 😅

@mdo mdo merged commit e304e6a into main Apr 3, 2025
14 checks passed
@mdo mdo deleted the main-lmp-list-group-action-color-fix branch April 3, 2025 06:38
@github-project-automation github-project-automation bot moved this from To do to Done in v5.3.4 Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

list-group-item-action color is overridden by list-group-item
2 participants