Removed role="document" from the modal dialog

[rohit2sharma95]

Closes #30687

Updated the document for the modal component.

[XhmikosR]

Not sure if this applies to v4 too @patrickhlauke

[ffoodd]

I'm not sure aria-modal should be shown in the examples markup: our scripts adds it when showing modal and removes it when hiding it. @patrickhlauke @Johann-S ?

[rohit2sharma95]

I'm not sure aria-modal should be shown in the examples markup: our scripts adds it when showing modal and removes it when hiding it.

@ffoodd is right though. @patrickhlauke and @Johann-S?

[patrickhlauke]

indeed, i forgot our scripts already handle aria-modal="true". so this really is just about removing the redundant role="document".

and yes should be done for v4 as well.

[patrickhlauke]

leave out all the additions of aria-modal="true". just keep the removal of role="document" from the tests, code examples, and the explanatory paragraph of text

[rohit2sharma95]

Okay @patrickhlauke! Let me do it.

[XhmikosR]

@patrickhlauke please check again so that I backport this and include it in the upcoming v4.4.2 🙂

[ffoodd]

LGTM

[patrickhlauke]

@XhmikosR looks good to me. possibly in future we could even consider injecting the role="dialog" via scripting (the same way aria-modal="true" is being injected. one less thing for authors to worry about.

[XhmikosR]

Sounds good to me! Just make an issue about it so that we don't forget 🙂