Skip to content

Replace reboot monospace hack with system font stack issue #26228 #26257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Replace reboot monospace hack with system font stack issue #26228 #26257

merged 1 commit into from
Apr 24, 2018

Conversation

client9
Copy link
Contributor

@client9 client9 commented Apr 11, 2018

All test pass. Spot check on my personal site seems to be fine. Saves a whole 50 bytes minified, and 10 bytes compressed. 🔢

I left the odd "font-size: 1em" since I'm unclear exactly what this does. It's likely wrong (want rem) or un-necessarly or both, but this is enough change for this commit.

Comments welcome.

Fixes #26228

@XhmikosR
Copy link
Member

Only issue I see with this, is that the standalone reboot won't have this fix any longer. And it seems it's still required by some browsers.

Alternatively, maybe we could do this conditionally.

I'll leave the final decision to @mdo.

@client9
Copy link
Contributor Author

client9 commented Apr 11, 2018

hi @XhmikosR -- my understanding of the monospace hack is that some browser/os combos have a hardwired "if and only if the font-family is exactly "monospace" then do something stupid with sizing". This is why "monospace, monospace" prevents the issue. Using something other than monospace such as the system stack will also work correctly. Does this make sense? Or did I misunderstand your concern? regards, --nickg

@XhmikosR
Copy link
Member

Yeah, I understand this, but Bootstrap Reboot is a separate project/file.

@client9
Copy link
Contributor Author

client9 commented Apr 12, 2018

hi @XhmikosR Oh i see. For bootstrap is this a non-change (except smaller, less redundant rules), but for reboot it would change the font used (assuming it's not changed downstream). So that would be a @mdo decision on what to do. got it! thanks for your time guys. Let me know if you need any additional details. regards --nickg

@mdo mdo merged commit 755fdac into twbs:v4-dev Apr 24, 2018
@mdo mdo mentioned this pull request Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants