Generate CSS variables for -colors #23446
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay! Okay, this works great. I've tried it with postcss-custom-properties for non-Sass build usage, and also directly in the browser. Here's a GIF of the latter:
|
passcod
added a commit
to passcod/bootstrap
that referenced
this pull request
Aug 31, 2017
See twbs#23349 Supersedes twbs#23446
mdo
pushed a commit
that referenced
this pull request
Oct 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interesting idea proposed by #23349. We could build with Sass, but compile some utilities to help those not using our Sass-based compilation flow. I'd say we could even wrap these in conditionals to not include them unless asked for, but that'd defeat the purpose a bit.
I dunno how far we'd take this though...