Change $input-border-color to HEX color value #21318
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twbs-savage
pushed a commit
to twbs-savage/bootstrap
that referenced
this pull request
Apr 6, 2017
Add `$btn-secondary-border` border color for form control in input group in the navbar when there is a dark background. Because the normal border color is `rgba(0,0,0,.15)` and depend of the background color the input in input group seems to have no border. Fix twbs#21098 Close twbs#21318
|
I'm actually liking #22612 more than this PR. Will revisit after Beta 1 ships though, so punting this to the next release cycle. |
|
Going with #22612 in Beta 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two problems with input groups.
First is hover change of middle (not rounded) border color of input because of input & button borders overlay:
Second one is that now input color is not compatible with dark background:
after this PR:
Sorry if I didn't get why now
$input-border-colorhas RGBA value. But it will be great to fix this issues without changing z-indexes logic or any other major changes. Thanks!