Skip to content

Fix multi select box overflow #20779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Fix multi select box overflow #20779

wants to merge 7 commits into from

Conversation

indymx
Copy link

@indymx indymx commented Sep 24, 2016

This fixes multiple select box overflow issue.

Also found an extra text-decoration: underline in abbr[title]

indymx added 7 commits April 30, 2016 12:27
 border-style: $card-border-style;
 border-width: $card-border-width;

 to @mixin card-outline-variant

 added

 $card-border-style:   solid !default;

 to _variables.scss

 so card-outline-* would work
…alize.scss so that multi select boxes don't over flow their containers.

fixed abbr[title] to remove extra text-decoration
…alize.scss so that multi select boxes don't over flow their containers.

fixed abbr[title] to remove extra text-decoration
…alize.scss so that multi select boxes don't over flow their containers.

fixed abbr[title] to remove extra text-decoration
…alize.scss so that multi select boxes don't over flow their containers.

fixed abbr[title] to remove extra text-decoration
…alize.scss so that multi select boxes don't over flow their containers.

fixed abbr[title] to remove extra text-decoration
@mdo
Copy link
Member

mdo commented Sep 26, 2016

Is there a corresponding change in Normalize.css for this? We pull in this entire CSS file from them, so changing it is kind of a no-no as it's a dependency :).

@indymx
Copy link
Author

indymx commented Sep 26, 2016

I just checked their source, there is no "select" in the offending section.

from their source:
button, input { /* 1 */ overflow: visible; }

from _normalize.scss:

button, input, // 1 select { // 2 overflow: visible; }

@bardiharborow
Copy link
Member

This is already fixed in #20428 over two months ago. Just waiting for merge on that PR.

@indymx
Copy link
Author

indymx commented Oct 1, 2016

Any time frame for that merge?

On Fri, Sep 30, 2016, 7:15 PM Bardi Harborow [email protected]
wrote:

This is already fixed in #20428
#20428 over two months ago. Just
waiting for merge on that PR.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#20779 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA14zcgB_5IbT-fqqFJ-Jz_pTpGE1AC5ks5qvZgKgaJpZM4KFxI7
.

@mdo mdo mentioned this pull request Oct 3, 2016
@mdo
Copy link
Member

mdo commented Oct 3, 2016

Fixed in #20428.

@mdo mdo closed this Oct 3, 2016
@mdo mdo added this to the v4.0.0-alpha.5 milestone Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants