Skip to content

v4: Dropdown units #20701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2016
Merged

v4: Dropdown units #20701

merged 2 commits into from
Oct 3, 2016

Conversation

mdo
Copy link
Member

@mdo mdo commented Sep 12, 2016

Fixes #19784. Move from pixels to rems, add a margin-bottom: 0; to keep things aligned.

@mdo mdo added this to the v4.0.0-alpha.5 milestone Sep 12, 2016
@@ -140,6 +140,7 @@
// Dropdown section headers
.dropdown-header {
display: block;
margin-bottom: 0; // for use with heading elements

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered display, padding, margin-bottom, font-size, color, white-space

@mdo mdo merged commit a75330c into v4-dev Oct 3, 2016
@mdo mdo deleted the v4-dropdown-units branch October 3, 2016 01:25
@mdo mdo mentioned this pull request Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants