Skip to content

v4: Card image fixes #20667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2016
Merged

v4: Card image fixes #20667

merged 3 commits into from
Sep 8, 2016

Conversation

mdo
Copy link
Member

@mdo mdo commented Sep 7, 2016

  • Add .img-fluid to card images in columns to ensure proper resizing
  • Change the .card-img variable from regular value to $card-border-radius-inner
  • Use calc to figure out a tighter border for card images with $card-border-radius-inner

Fixes #20560.

@mdo mdo added this to the v4.0.0-alpha.5 milestone Sep 7, 2016
@mdo mdo merged commit 07752ba into v4-dev Sep 8, 2016
@mdo mdo deleted the card-img-fixes branch September 8, 2016 03:40
@mdo mdo mentioned this pull request Sep 8, 2016
@mdo mdo mentioned this pull request Sep 8, 2016
mdo added a commit that referenced this pull request Sep 8, 2016
Use proper Sass variable interpolation to ensure the proper values are compiled and not the literal string of the variable name
twbs-savage pushed a commit to twbs-savage/bootstrap that referenced this pull request Sep 8, 2016
Use proper Sass variable interpolation to ensure the proper values are compiled and not the literal string of the variable name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant