Skip to content

Switch to jQuery slim version. #20203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

XhmikosR
Copy link
Member

We don't use the extra features the normal build has.

See https://blog.jquery.com/2016/06/09/jquery-3-0-final-released/

/CC @cvrebert @hnrch02 @dmethvin for thoughts.

@cvrebert cvrebert added this to the v4.0.0-alpha.3 milestone Jun 29, 2016
@cvrebert
Copy link
Collaborator

👍

@hnrch02
Copy link
Collaborator

hnrch02 commented Jun 29, 2016

SGTM. Maybe we should add a note in the docs about the slim version and when to use it yourself?

@XhmikosR
Copy link
Member Author

Personally, I'd like to know what are the plans for the slim version, i.e. do they plan to keep releasing it or not. Apart from that, we should probably mention that the slim version works fine with Bootstrap v4 at this point.

@dmethvin
Copy link
Contributor

Usually once we add a build we don't take it away. If we did stop making it I would expect that to not happen until the next major version.

I think it's great that you're using the slim build. Most users will end up using a full build but this makes it possible for them to use slim or their own custom build.

@calvinf
Copy link

calvinf commented Jul 1, 2016

This makes sense as long as the Bootstrap v4 website makes it easy and clear that either jQuery 3.0 or 3.0 slim builds can be used.

@XhmikosR
Copy link
Member Author

XhmikosR commented Jul 2, 2016

Well I'm no good with writing docs. I'd rather merge this and address the
doc changes later with someone else's help for the docs.
On Jul 1, 2016 23:42, "Calvin Freitas" [email protected] wrote:

This makes sense as long as the Bootstrap v4 website makes it easy and
clear that either jQuery 3.0 or 3.0 slim builds can be used.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#20203 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAVVtYLSZ2ckwk4rOwXGkT2Uo25KCJT1ks5qRXvCgaJpZM4JA0Ql
.

@lorvent
Copy link

lorvent commented Jul 5, 2016

Personally i feel its better to use regular version.

even though you don't need functions like $.ajax those who uses bootstrap with server side languages needs them.

and if we download bootstrap through bower, if you ship slim version, people need to include regular version again.

and difference in size is just 6kb

@hnrch02
Copy link
Collaborator

hnrch02 commented Jul 5, 2016

@lorvent This only touches the jQuery files used in the docs/tests.

@lorvent
Copy link

lorvent commented Jul 5, 2016

oops...sorry about that

@XhmikosR XhmikosR force-pushed the v4-dev-xmr-jquery-slim branch from 3bacabb to 03968f0 Compare July 10, 2016 11:18
@XhmikosR XhmikosR force-pushed the v4-dev-xmr-jquery-slim branch from 03968f0 to afc1892 Compare July 12, 2016 15:09
@auvipy
Copy link

auvipy commented Jul 16, 2016

what about jquery 3.1?

@XhmikosR
Copy link
Member Author

Make a separate issue for that please.

On Jul 16, 2016 22:02, "Asif Saifuddin Auvi" [email protected]
wrote:

what about jquery 3.1?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#20203 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAVVtcauo4R63PHyvIhQlM3D6qhRQFRtks5qWSqrgaJpZM4JA0Ql
.

@mdo mdo modified the milestones: v4.0.0-alpha.3, v4.0.0-alpha.4 Jul 20, 2016
@bardiharborow
Copy link
Member

Just a heads up that this PR changes _config.yaml, which cascades to the example on docs/getting-started/introduction.md. I think changing that without clarifying further might be inadvisable.

@mdo
Copy link
Member

mdo commented Oct 10, 2016

Should we try to get this into Alpha 5? Seeing some conflicts preventing this from being merged.

@XhmikosR
Copy link
Member Author

This is obsolete and I need to update it. I'll do it tomorrow probably.

On Oct 10, 2016 22:55, "Mark Otto" [email protected] wrote:

Should we try to get this into Alpha 5? Seeing some conflicts preventing
this from being merged.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#20203 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAVVtekMZnBzuF8h0tX0GV29Sktej3zkks5qypgrgaJpZM4JA0Ql
.

@mdo mdo modified the milestones: v4.0.0-alpha.6, v4.0.0-alpha.5 Oct 17, 2016
@mdo mdo mentioned this pull request Dec 29, 2016
@mdo
Copy link
Member

mdo commented Dec 29, 2016

Replaced by #21466.

@mdo mdo closed this Dec 29, 2016
@mdo mdo removed this from the v4.0.0-alpha.6 milestone Dec 29, 2016
@mdo mdo deleted the v4-dev-xmr-jquery-slim branch December 29, 2016 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants