-
-
Notifications
You must be signed in to change notification settings - Fork 79.1k
Switch to jQuery slim version. #20203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👍 |
SGTM. Maybe we should add a note in the docs about the slim version and when to use it yourself? |
Personally, I'd like to know what are the plans for the slim version, i.e. do they plan to keep releasing it or not. Apart from that, we should probably mention that the slim version works fine with Bootstrap v4 at this point. |
Usually once we add a build we don't take it away. If we did stop making it I would expect that to not happen until the next major version. I think it's great that you're using the slim build. Most users will end up using a full build but this makes it possible for them to use slim or their own custom build. |
This makes sense as long as the Bootstrap v4 website makes it easy and clear that either jQuery 3.0 or 3.0 slim builds can be used. |
Well I'm no good with writing docs. I'd rather merge this and address the
|
Personally i feel its better to use regular version. even though you don't need functions like and if we download bootstrap through bower, if you ship slim version, people need to include regular version again. and difference in size is just 6kb |
@lorvent This only touches the jQuery files used in the docs/tests. |
oops...sorry about that |
3bacabb
to
03968f0
Compare
We don't use the extra features the normal build has. See https://blog.jquery.com/2016/06/09/jquery-3-0-final-released/
03968f0
to
afc1892
Compare
what about jquery 3.1? |
Make a separate issue for that please. On Jul 16, 2016 22:02, "Asif Saifuddin Auvi" [email protected]
|
Just a heads up that this PR changes _config.yaml, which cascades to the example on docs/getting-started/introduction.md. I think changing that without clarifying further might be inadvisable. |
Should we try to get this into Alpha 5? Seeing some conflicts preventing this from being merged. |
This is obsolete and I need to update it. I'll do it tomorrow probably. On Oct 10, 2016 22:55, "Mark Otto" [email protected] wrote:
|
Replaced by #21466. |
We don't use the extra features the normal build has.
See https://blog.jquery.com/2016/06/09/jquery-3-0-final-released/
/CC @cvrebert @hnrch02 @dmethvin for thoughts.