Add media rules to nav items into toggleable navbar #20083
Conversation
| @@ -174,6 +174,20 @@ | |||
| } | |||
| } | |||
|
|
|||
| // Navigation items into toggleable navbar | |||
| .navbar-nav { | |||
| .nav-item { | |||
There was a problem hiding this comment.
We're generally trying to avoid nesting, especially more than 1 level of it.
Is the .navbar-nav .nav-item part really necessary?
|
@cvrebert Yes, because it must to rewrire |
|
No, it's fine as-is then. |
|
Just to know, is there a reason why this is still opened? If it passes all the tests and everything, I just don't get why it's not merged, could someone kindly explain without jumping on me ? |
|
@os1r1s110 None of the core team work on Bootstrap as part of their jobs. It's an entirely nights-and-weekends affair. So we don't always have time to deal with PRs quickly. |
|
CC: @mdo |
|
@cvrebert Just to let you know, I completely understand it and my comment was not intended to be negative in any way. I really appreciate the work all of the core team and contributors are doing. The question was simply to understand if something I didn't understand was blocking the PR to get merged except for time missing. The real thing I didn't understand was that on June 6th, all tests had passed and you had "confirmed" kvlsrg's way of doing the modification, so I didn't get why it wasn't merged on this day as in my understanding, if all integration tests and everything passes, merge should/could be a breeze no? If not, sorry for my misunderstanding. Thanks again for your time and have a good day! |
|
Pulled this into |
|
Thanks! |
PR to fix alignment of nav items into toggleable navbar
Here two before states of items in mobile dropdown of navbar:
And this is after that I get with changes (in this PR):