Skip to content

Add $card-img-overlay-padding variable #19252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2016
Merged

Conversation

cvrebert
Copy link
Collaborator

CC: @mdo for review

[skip sauce]
[skip variable]
@mdo
Copy link
Member

mdo commented Feb 17, 2016

Should probably use the $card-spacer-* vars here instead?

@cvrebert
Copy link
Collaborator Author

@mdo Ah I see. But that would involve using $card-spacer-x for padding on all sides of the overlay, which is weird. So seems like we need to rejigger the variables or styles more.

@mdo
Copy link
Member

mdo commented May 8, 2016

Yeah, will clean up those variables later. For now, getting this one in.

@mdo mdo merged commit 017258d into v4-dev May 8, 2016
@mdo mdo deleted the card-img-overlay-padding branch May 8, 2016 20:36
@mdo mdo mentioned this pull request May 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants