Skip to content

Focus (visually hidden) input radio/checkbox #19222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2016
Merged

Focus (visually hidden) input radio/checkbox #19222

merged 1 commit into from
Feb 16, 2016

Conversation

patrickhlauke
Copy link
Member

This allows for keyboard navigation (e.g. arrow keys left/right to trigger different radio buttons) following an initial mouse click interaction on a radio button or checkbox

A simplified port of #19192 to the new v4 code base

This allows for keyboard navigation (e.g. arrow keys left/right to
trigger different radio buttons) following an initial mouse click
interaction
@patrickhlauke
Copy link
Member Author

Savage appears to be stuck. As local tests and Travis don't report anything untowards, I'm going to be bold and merge...

patrickhlauke added a commit that referenced this pull request Feb 16, 2016
…box-radio-toggle-port1

Focus (visually hidden) input radio/checkbox
@patrickhlauke patrickhlauke merged commit 9e57584 into twbs:v4-dev Feb 16, 2016
@mdo mdo mentioned this pull request Feb 16, 2016
@cvrebert
Copy link
Collaborator

We might be able to use raw DOM's https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/focus instead of jQuery here.

@patrickhlauke
Copy link
Member Author

Ah sorry, already merged. But would our preference be to go vanilla instead of jquery then?

@cvrebert
Copy link
Collaborator

The strategy for v4's JS seems to be to not use jQuery in cases where it doesn't really buy us anything. It's more performant if nothing else.

@maugusto-cit
Copy link

@patrickhlauke , it seems this issue has been tackled many times, but it also seems it is back in the latest version (4 alpha 5). If you check the sample here, you'll see that keyboard navigation (in Safari) is not changing the checked attribute in the input radio. Should I report a new issue?

@patrickhlauke
Copy link
Member Author

@maugusto-cit yeah this issue is still not fixed :( i made a start over here #18874 but need to find some time to take it further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants