Skip to content

Docs: add/unify advice on contextual colors and accessibility #18676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Docs: add/unify advice on contextual colors and accessibility #18676

wants to merge 7 commits into from

Conversation

patrickhlauke
Copy link
Member

  • add callout warning about conveying meaning to assistive technologies when using color modifiers
  • use more generalised callout text where already present

@cvrebert
Copy link
Collaborator

Perhaps we could use Jekyll's include directive rather than having the same text copypasta'd in multiple places?

@patrickhlauke
Copy link
Member Author

Don't know anything about Jekyll, but this http://wolfslittlestore.be/2013/10/rendering-markdown-in-jekyll/ seems to put a spanner in the works unless the fragment's already in HTML?

@cvrebert
Copy link
Collaborator

We're already using custom Jekyll plugins, so we might as well add the one from the post you linked to.

@patrickhlauke
Copy link
Member Author

I'll need somebody to either give me some massive pointers...or do it before I break everything ;) (i.e. grunt and co are a complete black box mystery to me, sadly)

@cvrebert
Copy link
Collaborator

I'll take a crack at the Jekyll plugin.

@patrickhlauke
Copy link
Member Author

i had a few attempts at doing the jekyll plugin thing. however, it ended up giving me all sorts of annoying side effects (like complaining about %endmarkdown in the getting started download.md file), and needed to be unnecessarily hacked (to make sure the includes were grabbed explicitly from docs/_includes). decided to go the slightly more wordy, but perfectly legit route of

{% capture my-include %}{% include test.md %}{% endcapture %}
{{ my-include | markdownify }}

instead. closing this in favor of the successor PR #19255

@patrickhlauke patrickhlauke deleted the docs-color-accessibility1 branch February 17, 2016 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants