Refactor Breadcrumbs component #18474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvrebert
force-pushed
the
breadcrumbs-2.0
branch
from
da7d0db to
99730f3
Compare
|
Ability to choose your own font in sass like FontAwesome and use his icon |
|
@yasinkocak That's out of scope for a mere refactoring. |
|
Note to self: A migration guide entry needs to be added for this. |
Use new `.breadcrumb-item` class instead of child selectors and `li` tag selectors, so as to no longer require the usage of `<ol>`-based markup. Rename variables to follow naming conventions: * $breadcrumb-padding-vertical => $breadcrumb-padding-y * $breadcrumb-padding-horizontal => $breadcrumb-padding-x Introduce new variable: $breadcrumb-item-padding [skip sauce]
cvrebert
force-pushed
the
breadcrumbs-2.0
branch
from
99730f3 to
76a4c30
Compare
|
Wrote an entry in the migration guide. |
cvrebert
added a commit
that referenced
this pull request
Dec 24, 2015
Refactor Breadcrumbs component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use new
.breadcrumb-itemclass instead of child selectors andlitag selectors, so as to no longer require the usage of<ol>-based markup.Rename variables to follow naming conventions:
Introduce new variable: $breadcrumb-item-padding
CC: @mdo for review