Skip to content

Add float in make-col-span() mixin, not make-col() #17514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add float in make-col-span() mixin, not make-col() #17514

wants to merge 1 commit into from

Conversation

jfarthing84
Copy link

Fixes #17512.

@cvrebert cvrebert mentioned this pull request Sep 7, 2015
Closed
@cvrebert
Copy link
Collaborator

cvrebert commented Sep 7, 2015

Huh. Seems like make-col() might be dead code.

@jfarthing84
Copy link
Author

http://v4-alpha.getbootstrap.com/layout/grid/#example-usage

@mdo
Copy link
Member

mdo commented Sep 28, 2015

make-col() was intended to avoid a lot of duplication in responsive grid systems—putting the min-height and padding on the other mixin would duplicate that each time you added a new tier.

@mdo mdo added the on-hold label Nov 13, 2015
@mdo mdo mentioned this pull request Dec 8, 2015
Closed
17 tasks
@mdo mdo added this to the v4.0.0-alpha.3 milestone Feb 6, 2016
@mdo mdo mentioned this pull request Feb 6, 2016
Merged
1 task
@mdo
Copy link
Member

mdo commented Feb 6, 2016

Coming at you with fresh mixins in #19099.

@mdo mdo closed this Feb 6, 2016
@julien-gargot julien-gargot mentioned this pull request Feb 10, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
css on-hold v4
Projects
None yet
Milestone
v4.0.0-alpha.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jfarthing84 @cvrebert @mdo