inline svg: base64 > ASCII85 #17476
Closed
inline svg: base64 > ASCII85 #17476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cvrebert: so how about this? It sort of makes sense since those SVGs are small. |
|
SGTM. |
|
The SVGs need to be URL encoded to support IE 11 and below. |
|
@slavanga Yup, that's why Oleg's code has See also http://codepen.io/Tigt/post/optimizing-svgs-in-data-uris |
|
@cvrebert ah right, I always thought the whole thing has to be encoded. Thank you for the hint. |
|
Gotta balance this with #17222. |
|
Punting for #17222. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASCII significantly reduces size.
Preview - http://sassmeister.com/gist/031303db9b45b7ed1a24