Fix element precision bug in at media CSS elements widths #17388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(max-width: 33.999999em). For bug example : http://v4-alpha.getbootstrap.com/layout/responsive-utilities/ with a layout of 750px, hidden-sm-down and hidden-md-up are visible boths.
|
Partially duplicates #17283. |
glebm
added a commit
that referenced
this pull request
Aug 31, 2015
Changes grid and container sizes to `px`, as the viewport pixel size does not depend on the font size. The actual em values were inconsistent with the docs, while the docs were also inconsistent with the comments, namely: * `sm` breakpoint was 34em which is 558px, not 480px. Changed to 480px, matching the docs and Bootstrap 3. * `lg` max width was 60rem which is 960px, less gutter than `md`. Changed to 940px, same as Bootstrap 3. * `xl` max width was 72.25rem which is 1140px not 1156px. Changed to 1140px matching the comment but not the docs. All the values are now the same as they were in Bootstrap 3. Addresses #17070 and #17388.
|
Two popular Sass mixins for handling media queries (see below) substract 0.01em by default so I think that should be enough. https://github.com/sass-mq/sass-mq |
|
1 em ~= 16 px (or 14px) so 1px ~= 0.0625em (0,0714..em). Le 01/09/2015 11:45, Sergio Lavanga a écrit :
|
glebm
added a commit
that referenced
this pull request
Sep 2, 2015
Changes grid and container sizes to `px`, as the viewport pixel size does not depend on the font size. The actual em values were inconsistent with the docs, while the docs were also inconsistent with the comments, namely: * `sm` breakpoint was 34em which is 558px, not 480px. Changed to 480px, matching the docs and Bootstrap 3. * `lg` max width was 60rem which is 960px, less gutter than `md`. Changed to 940px, same as Bootstrap 3. * `xl` max width was 72.25rem which is 1140px not 1156px. Changed to 1140px matching the comment but not the docs. All the values are now the same as they were in Bootstrap 3. Addresses #17070 and #17388.
glebm
added a commit
that referenced
this pull request
Sep 8, 2015
Changes grid and container sizes to `px`, as the viewport pixel size does not depend on the font size. The actual em values were inconsistent with the docs, while the docs were also inconsistent with the comments, namely: * `sm` breakpoint was 34em which is 558px, not 480px. Changed to 480px, matching the docs and Bootstrap 3. * `lg` max width was 60rem which is 960px, less gutter than `md`. Changed to 940px, same as Bootstrap 3. * `xl` max width was 72.25rem which is 1140px not 1156px. Changed to 1140px matching the comment but not the docs. All the values are now the same as they were in Bootstrap 3. Addresses #17070 and #17388.
glebm
added a commit
that referenced
this pull request
Sep 16, 2015
Changes grid and container sizes to `px`, as the viewport pixel size does not depend on the font size. The actual em values were inconsistent with the docs, while the docs were not the same as the comments: * `sm` breakpoint was 34em (544px) not 480px. * `lg` container max-width was 60rem (960px), less gutter than `md`. Changed to 940px, same as Bootstrap 3. * `xl` container max-width was 72.25rem which is 1140px not 1156px. Changed to 1140px matching the comment but not the docs. Addresses #17070 and #17388.
glebm
added a commit
that referenced
this pull request
Sep 27, 2015
Changes grid and container sizes to `px`, as the viewport pixel size does not depend on the font size. The actual em values were inconsistent with the docs, while the docs were not the same as the comments: * `sm` breakpoint was 34em (544px) not 480px. * `lg` container max-width was 60rem (960px), less gutter than `md`. Changed to 940px, same as Bootstrap 3. * `xl` container max-width was 72.25rem which is 1140px not 1156px. Changed to 1140px matching the comment but not the docs. Addresses #17070 and #17388.
|
Fixed by #17403. |
tylerodonnell
pushed a commit
to picdorsey/frunt
that referenced
this pull request
Nov 5, 2015
Change grid and container sizes to px twbs/bootstrap@eabed0e >> Changes grid and container sizes to `px`, as the viewport pixel size does not depend on the font size. >> The actual em values were inconsistent with the docs, while the docs were not the same as the comments: Also will fix element precision bug in at media CSS elements widths (twbs/bootstrap#17388)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more precision with @media (max-width: 33.9em) changed to @media (max-width: 33.999999em).
For bug example : http://v4-alpha.getbootstrap.com/layout/responsive-utilities/ with a layout of 750px, hidden-sm-down and hidden-md-up are visible both.