Skip to content

Adds custom animation to tooltips & popovers #13711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

nanuclickity
Copy link

Implements #13622.

$('.logo').tooltip({
  animation: 'animated flipInX'
});

options.animation can now accept a class name and toggle it on show and hide events.
The options.animation default key has been updated to 'fade'.
Animation class modifications are done after everything is ready.
@nanuclickity nanuclickity changed the title Adds custom animation to tooltips #13622 Adds custom animation to tooltips. May 30, 2014
@nanuclickity nanuclickity changed the title Adds custom animation to tooltips. Adds custom animation to tooltips May 30, 2014
@cvrebert cvrebert changed the title Adds custom animation to tooltips Adds custom animation to tooltips & popovers May 30, 2014
@cvrebert
Copy link
Collaborator

  • The docs for the animation tooltip+popover parameter need to be updated too.
  • This needs to implement a fallback so that explicitly passing animation: true / false will still work, for backward compatibility.

@cvrebert
Copy link
Collaborator

Also, this code still contains several hardcoded references to fade.

Removed instances of `.fade` and animation changes now point to options.animation param.
@mdo
Copy link
Member

mdo commented Jul 7, 2014

I'm still very interested in seeing this happen, but I don't think it can until v4 (since we're not doing a v3.3.0).

Thoughts @cvrebert and @nanuclickity?

@cvrebert
Copy link
Collaborator

cvrebert commented Jul 7, 2014

Agreed.

@mdo
Copy link
Member

mdo commented Jul 7, 2014

Punted (and on the list).

@mdo mdo closed this Jul 7, 2014
@nanuclickity
Copy link
Author

Agreed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants