Skip to content

Fix vertical alignment for datetime-local inputs on iOS #13099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix vertical alignment for datetime-local inputs on iOS #13099

wants to merge 3 commits into from

Conversation

robfletcher
Copy link

Fixes #13098

@cvrebert cvrebert added the css label Mar 17, 2014
@cvrebert cvrebert added this to the v3.2.0 milestone Mar 17, 2014
@cvrebert
Copy link
Collaborator

We should check all the HTML5 temporal inputs on iOS to see which of them require this fix.

@robfletcher
Copy link
Author

I believe time is the only other one supported on iOS as datetime was dropped. I'll check it and update the pull request.

@robfletcher
Copy link
Author

The month and time types experience the same vertical alignment issues. It appears that iOS no longer supports datetime or week (possibly never did in the case of week).

I've updated my pull request to include the 2 additional types.

mdo
mdo reviewed Mar 20, 2014
View reviewed changes
less/forms.less
@@ -170,7 +170,7 @@ input[type="search"] {
// given height of the input. Since this fucks up everything else, we have to
// appropriately reset it for Internet Explorer and the size variations.

input[type="date"] {
input[type="date"], input[type="time"], input[type="datetime-local"], input[type="month"] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Break this onto separate lines and rebase into a single commit please?

@cvrebert cvrebert closed this in 1be0b57 Mar 20, 2014
@mdo mdo mentioned this pull request Mar 21, 2014
Closed
stempler pushed a commit to stempler/bootstrap that referenced this pull request Nov 4, 2014
@robfletcher @cvrebert
(less) Fix vertical alignment of temporal inputs on iOS
b50f958 
Fixes twbs#13098
Closes twbs#13099
@cvrebert cvrebert mentioned this pull request Dec 20, 2014
Merged
@cvrebert cvrebert mentioned this pull request May 14, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
browser-bug confirmed css
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

input type datetime-local text not vertically centered on iOS
3 participants
@robfletcher @cvrebert @mdo