Skip to content

List group item hover issue #35869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
XhmikosR opened this issue Feb 19, 2022 · 8 comments · Fixed by #36018
Closed
3 tasks done

List group item hover issue #35869

XhmikosR opened this issue Feb 19, 2022 · 8 comments · Fixed by #36018

Comments

@XhmikosR
Copy link
Member

Prerequisites

Describe the issue

Hovering over a list item seems to lose color. Not sure if it's intentional.

Reduced test cases

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Firefox

What version of Bootstrap are you using?

main

@gdibble
Copy link

gdibble commented Feb 22, 2022

Also noticing this on macOS Monterey 12.1 in Safari, Chrome and Firefox

@gdibble
Copy link

gdibble commented Feb 22, 2022

I'm running this locally and getting the same outcome as on the netlify deployment. Trying to get a build locally to match the getbootstrap output. I find the cascading order (and thus the line-number differences interesting and quite telling.

@XhmikosR, if I do not submit a PR before you then please let me know what I can do if anything at all to assist. 👍

image

Note that my working code via npm run docs-serve produce the same cascading order and line-numbers as those on the getbootstrap site, however my hover effect matches that on netlify.

image

image

@gdibble
Copy link

gdibble commented Feb 22, 2022

Cascading order in /scss/_list-group.scss looks correct.
Is it possible that the main site deployment is out of date with Anton's fix?
image

Ah! @XhmikosR was right about v5.2. Fixed in https://github.com/twbs/bootstrap/pull/35759/files#diff-5acbd4a53dcb8f76abf2cef498ae5a8c5d173ff48ae537c825afa5739a5b5bf0R85

@gdibble
Copy link

gdibble commented Feb 22, 2022

btw ty @WinterSilence 🙌

@WinterSilence
Copy link
Contributor

@gdibble yes, my fix can be not complete, sometimes it's happening :) p.s. what's is "btw ty"?

@gdibble
Copy link

gdibble commented Feb 22, 2022

@gdibble yes, my fix can be not complete, sometimes it's happening :) p.s. what's is "btw ty"?

@WinterSilence I understand ☺️ Just wanted to help a bit; hope that's okay

[btw] By The Way, meaning "also..."
[ty] Thank You

@mdo
Copy link
Member

mdo commented Mar 14, 2022

Caused by #35869, which I'm reverting. To fix the original issue mentioned in that PR, change the order of the custom CSS classes.

mdo added a commit that referenced this issue Mar 14, 2022
@mdo mdo mentioned this issue Mar 14, 2022
mdo added a commit that referenced this issue Mar 17, 2022
mdo added a commit that referenced this issue Mar 17, 2022
@gdibble
Copy link

gdibble commented Mar 18, 2022

Thanks @mdo, you rock 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants