-
-
Notifications
You must be signed in to change notification settings - Fork 79.1k
Docs: carousel, collapse, navs (tabs), popovers should use buttons rather than faked link buttons #31186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@XhmikosR I would like to work on this part of improving the documentation. I'll update the team regarding it as soon as possible. Can you assign this to me? |
We don't assign issues to people and there's no need to ask for permission :) Just grab an issue, work on it and make a PR when ready. |
@patrickhlauke @XhmikosR I'm currently working on it and got stuck in this https://v5.getbootstrap.com/docs/5.0/components/navs/#javascript-behavior Could you please provide any advice about replacing the anchor tag with the button on this part, if I have understood this issue properly? |
Carousels will be addressed by #32627 and #32661 |
Closing this as - apart from popovers using links, which is still necessary with our current approach due to Safari/macOS's odd duck behaviour, copied by Firefox/macOS - all major things are now sorted. |
Uh oh!
There was an error while loading. Please reload this page.
There's no good reason (other than ease of styling) for https://v5.getbootstrap.com/docs/5.0/components/carousel/, https://v5.getbootstrap.com/docs/5.0/components/collapse/, https://v5.getbootstrap.com/docs/5.0/components/navs/#javascript-behavior, https://v5.getbootstrap.com/docs/5.0/components/popovers/#dismiss-on-next-click to use
<a href="#..." role="button">...</a>
pseudo-buttons. While sure, BS can still support this, it'd be good to lead by example and use the correct<button>
element for this (though I don't believe we have a neutral-enough button style out of the box to support carousel buttons...or at least, the current carousel controls need to be extended to neutralise the remaining button styles that creep in when swapping out the elements).The text was updated successfully, but these errors were encountered: