You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
key events are not propagated from dropdown when it is inactive or disabled.
Reduced test case on JS Bin: https://jsbin.com/hoharusisa there is ESC key handler attached to the document element.
Click on ESC - nothing happens.
Click on ESC - handler is invoked.
Event propagation is disabled in the https://github.com/twbs/bootstrap/blob/v4-dev/js/src/dropdown.js#L455 just after initial checks which are finishing the event handling, but in following lines there are further check which potentially could finish the handling. Propagation should be stopped after those checks.
Please see related PR with the fix.
Similar finding was created for v3: #15065 It was found as valid issue: #15065 (comment) however it was never fixed.
Thanks ans Regards,
Łukasz
The text was updated successfully, but these errors were encountered:
luktom
added a commit
to luktom/bootstrap
that referenced
this issue
Apr 3, 2020
Hi,
key events are not propagated from dropdown when it is inactive or disabled.
Reduced test case on JS Bin: https://jsbin.com/hoharusisa there is ESC key handler attached to the document element.
Event propagation is disabled in the https://github.com/twbs/bootstrap/blob/v4-dev/js/src/dropdown.js#L455 just after initial checks which are finishing the event handling, but in following lines there are further check which potentially could finish the handling. Propagation should be stopped after those checks.
Please see related PR with the fix.
Similar finding was created for v3: #15065 It was found as valid issue: #15065 (comment) however it was never fixed.
Thanks ans Regards,
Łukasz
The text was updated successfully, but these errors were encountered: