Skip to content

Bottom margin with radio button group #20784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andreasschiestl opened this issue Sep 25, 2016 · 2 comments
Closed

Bottom margin with radio button group #20784

andreasschiestl opened this issue Sep 25, 2016 · 2 comments

Comments

@andreasschiestl
Copy link

andreasschiestl commented Sep 25, 2016

Hi!

I noticed that there is a button margin with radio button groups, but not with normal button groups.

bildschirmfoto 2016-09-25 um 21 45 54

bildschirmfoto 2016-09-25 um 21 46 32

code used for this example

<div class="btn-group btn-group-sm" role="group">
    <button type="button" class="btn btn-secondary">Left</button>
    <button type="button" class="btn btn-secondary">Middle</button>
    <button type="button" class="btn btn-secondary">Right</button>
</div>

<div class="btn-group btn-group-sm" data-toggle="buttons">
    <label class="btn btn-secondary">
        <input type="radio" name="options" id="option1" autocomplete="off"> Radio 1
    </label>
    <label class="btn btn-secondary">
        <input type="radio" name="options" id="option2" autocomplete="off"> Radio 2
    </label>
    <label class="btn btn-secondary">
        <input type="radio" name="options" id="option3" autocomplete="off"> Radio 3
    </label>
</div>

The bottom margin is created by the label tag.

@cvrebert
Copy link
Collaborator

Please make a CodePen, JS Bin, or other live example that demonstrates the bug.

@andreasschiestl
Copy link
Author

Here is a JS Bin example :) https://jsbin.com/yicopuz/2/edit?html,output

@mdo mdo added v4 and removed awaiting-reply labels Oct 3, 2016
@mdo mdo added this to the v4.0.0-alpha.5 milestone Oct 3, 2016
mdo added a commit that referenced this issue Oct 3, 2016
- Fixes #20298 for vertical button group spacing
- Fixes #20784 for horizontal (default) button group spacing
- Alternate fix to #20823 which only applied a fix for vertical button groups
@mdo mdo closed this as completed in #20827 Oct 3, 2016
twbs-savage pushed a commit to twbs-savage/bootstrap that referenced this issue Oct 3, 2016
- Fixes twbs#20298 for vertical button group spacing
- Fixes twbs#20784 for horizontal (default) button group spacing
- Alternate fix to twbs#20823 which only applied a fix for vertical button groups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants