Skip to content

Integrity attribute is incorrect in the documentation #20692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lilHermit opened this issue Sep 10, 2016 · 7 comments
Closed

Integrity attribute is incorrect in the documentation #20692

lilHermit opened this issue Sep 10, 2016 · 7 comments

Comments

@lilHermit
Copy link

The integrity attribute is missing the hash algorithm in the docs at http://v4-alpha.getbootstrap.com/getting-started/introduction/.

Reads
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.4/js/bootstrap.min.js" integrity="VjEeINv9OSwtWFLAtmc4JCtEJXXBub00gtSnszmspDLCtC0I4z4nqz7rEFbIZLLU" crossorigin="anonymous"></script>

should be
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.4/js/bootstrap.min.js" integrity="sha384-VjEeINv9OSwtWFLAtmc4JCtEJXXBub00gtSnszmspDLCtC0I4z4nqz7rEFbIZLLU" crossorigin="anonymous"></script>

@TheBuzzer67
Copy link

TheBuzzer67 commented Sep 10, 2016

Is it the same for the css??

<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.4/css/bootstrap.min.css" integrity="sha384-2hfp1SzUoho7/TsGGGDaFdsuuDL0LX2hnUp6VkX3CUQ2K4K+xjboZdsXyp4oUHZj" crossorigin="anonymous">

@lilHermit
Copy link
Author

lilHermit commented Sep 10, 2016

I'm not using the css link, I'm building via scss but yeah it would be

Java console
Error parsing 'integrity' attribute ('2hfp1SzUoho7/TsGGGDaFdsuuDL0LX2hnUp6VkX3CUQ2K4K+xjboZdsXyp4oUHZj'). The hash algorithm must be one of 'sha256', 'sha384', or 'sha512', followed by a '-' character.

@TheBuzzer67
Copy link

Someone will have to explain me how scss works, I tried something and it doesn't work for me, do you have something to read to help me work with SASS files?

akamch added a commit to akamch/bootstrap that referenced this issue Sep 10, 2016
twbs-savage pushed a commit to twbs-savage/bootstrap that referenced this issue Sep 12, 2016
@mdo
Copy link
Member

mdo commented Sep 12, 2016

Fixed by #20694.

@mdo mdo closed this as completed Sep 12, 2016
@mdo mdo added this to the v4.0.0-alpha.5 milestone Sep 12, 2016
@mdo
Copy link
Member

mdo commented Sep 12, 2016

I pushed a manual fix to our docs, too.

@KerryRuddock
Copy link

New to bootstrap. Just wanted to say that this issue still exists under the starter template.
I used the fixes from the Quick Start section to resolve issue#20692

@ericrayanderson
Copy link

ericrayanderson commented Sep 27, 2016

Reiterate the comment above, issue still exists with Starter template here:

https://v4-alpha.getbootstrap.com/getting-started/introduction/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants