Skip to content

Docs are contradictory for radio/checkbox classes #20608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheSharpieOne opened this issue Sep 1, 2016 · 1 comment
Closed

Docs are contradictory for radio/checkbox classes #20608

TheSharpieOne opened this issue Sep 1, 2016 · 1 comment

Comments

@TheSharpieOne
Copy link

TheSharpieOne commented Sep 1, 2016

Slightly different from #20578 which is specific to inline and stacking, this ticket hopes to address the .form-check vs .radio and .checkbox classes.

The checkboxes and radios example uses the .form-check class exclusively while the validation example uses .radio and .checkbox exclusively.
It is also worth noting that the validation styles for the label depend on the use of .radio and .checkbox

EDIT: Also affects disabled styles. The docs show both ways. Using .radio, as shown in the form controls example, does not make the label gray when disabled. Using .form-check does make the label gray when it is disabled` as seen in the using the grid example

.radio.disabled label
radio-disabled
.form-check.disabled .form-check-label
form-check-disabled

mdo added a commit that referenced this issue Sep 5, 2016
- Update docs examples to use newer .form-check suite of classes
Update form validation mixin to use newer classes as well
@mdo mdo added this to the v4.0.0-alpha.4 milestone Sep 5, 2016
twbs-savage pushed a commit to twbs-savage/bootstrap that referenced this issue Sep 5, 2016
…twbs#20629)

- Update docs examples to use newer .form-check suite of classes
- Update form validation mixin to use newer classes as well
@mdo
Copy link
Member

mdo commented Sep 5, 2016

Fixed by #20629.

@mdo mdo closed this as completed Sep 5, 2016
krissihall pushed a commit to krissihall/bootstrap that referenced this issue Sep 7, 2016
…0_aeo-bootstrap

* 'v4-dev' of https://github.com/twbs/bootstrap: (860 commits)
  Update Bower url (HTTP to HTTPS) (twbs#20658)
  Add Edge entry for twbs#20507 to Wall of Browser Bugs
  Move Sauce credentials out of .travis.yml
  new hashes
  grunt
  versions
  grunt
  Fixes twbs#20608 and twbs#20578: Consistent checkbox and radio markup (twbs#20629)
  Disable important flag on Sass linter (twbs#20627)
  Fixes twbs#20619: Add important to the hover/focus as well (twbs#20626)
  grunt
  Fix segmented buttons in input group docs (twbs#20489)
  Renamed contextual classes for tables (twbs#20505)
  Make .card class inside .card-columns display: block too (twbs#20447)
  grunt
  Remove unused $variables in grid mixins (twbs#20597)
  fixes twbs#20485: use rem units in alert dismiss (twbs#20625)
  Fix README badge alignment.
  Update ads code and styles (also fixes twbs#20477 in different way)
  Fixes twbs#20504: Mention .divider to .dropdown-divider name change
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants