Skip to content

Rename .btn-*-outline to .btn-outline-* #17719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pinin opened this issue Sep 27, 2015 · 2 comments
Closed

Rename .btn-*-outline to .btn-outline-* #17719

pinin opened this issue Sep 27, 2015 · 2 comments

Comments

@pinin
Copy link

pinin commented Sep 27, 2015

health men, just my opinion
I think the class names for button style outline in v4, it should be following

... class="btn btn-outline-primary" ...
... class="btn btn-outline-secondary" ...
... class="btn btn-outline-success" ...
... class="btn btn-outline-warning" ...
... class="btn btn-outline-danger" ...

instead of

... class="btn btn-primary-outline" ...
... class="btn btn-secondary-outline" ...
... class="btn btn-success-outline" ...
... class="btn btn-warning-outline" ...
... class="btn btn-danger-outline" ...

that is not only a clearer, but can be used for example, another modification as

[class^='btn-outline-'],
[class*=' btn-outline-'] { ... }

which is not possible now

@cvrebert
Copy link
Collaborator

that is not only a clearer, but can be used for example, another modification as

[class^='btn-outline-'],
[class*=' btn-outline-'] { ... }

I believe we're trying to avoid those sorts of selectors for performance and extensibility reasons.

@cvrebert cvrebert changed the title v4 button outline Modifier Rename .btn-*-outline to .btn-outline-* Sep 27, 2015
@mdo mdo added this to the v4.0.0-alpha.3 milestone Jan 6, 2016
@mdo
Copy link
Member

mdo commented Jan 6, 2016

Changed in #18772.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants