Skip to content

Don't break backward compatibility in v4 #17240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iang0ld opened this issue Aug 23, 2015 · 9 comments
Closed

Don't break backward compatibility in v4 #17240

iang0ld opened this issue Aug 23, 2015 · 9 comments

Comments

@iang0ld
Copy link

iang0ld commented Aug 23, 2015

I didn't know where else to post this...

Please consider lessons from the success of jQuery, and how commercial companies grow loyal customers; about the Angular 2 mistake and the sudden growth of React due to uncertainty about Angular. Let us all move forward with Bootstrap without throwing away all the good work the community has done.

Please don't encourage us to look for alternatives. Consider the benefits of backward compatibility - consistency, protection and respect for users time and effort.

Keep wells, panels, etc. in Bootstrap 4. Depreciate old selectors rather that remove them. We want to move forward with Bootstrap 4. Don't break what already works. Let just do better in the future.

From a dedicated user from the beginning.

@kkirsche
Copy link
Contributor

@iang0ld Major version changes by definition in semantic versioning are for non-backwards compatible changes. That is one aspect of it which I do personally think is important.

I also think that after 2 years, Bootstrap needs to be able to upgrade and move to more current best practices as well as re-evaluate it's own current practices as it is doing in V4.

Honestly, I don't think this is an instance such as what occurred with Angular 1 -> 2 or Python 2 -> 3. Every prior instance has been a rewrite and we are working on migration documents for users. I also have interest in creating a migration script to automate it for people.

But I don't believe it's fair to Bootstrap as a project to force it to maintain compatibility because it would inconvenience developers who would need to update their sites or come to grips with the changes.

@iang0ld
Copy link
Author

iang0ld commented Aug 23, 2015

I agree to disagree.

In my world I cannot inconvenience customers or I do not eat, I lose money when I have to rewrite code, and I use HTML, CSS, SQL, C#, PHP and JavaScript because they are backward-compatible, despite major version changes. I envy you for not being in that position.

Nonetheless, Bootstrap 4 looks like a great product. Congratulations!

From: Kevin Kirsche [mailto:[email protected]]
Sent: Sunday, 23 August 2015 10:28 PM
To: twbs/bootstrap [email protected]
Cc: Ian Gold [email protected]
Subject: [BULK] Re: [bootstrap] Oh no ??!! - We have to start again. Haven't we learn't. (#17240)

@iang0ldhttps://github.com/iang0ld Major version changes by definition in semantic versioning are for non-backwards compatible changes. That is one aspect of it which I do personally think is important.

I also think that after 2 years, Bootstrap needs to be able to upgrade and move to more current best practices as well as re-evaluate it's own current practices as it is doing in V4.

Honestly, I don't think this is an instance such as what occurred with Angular 1 -> 2 or Python 2 -> 3. Every prior instance has been a rewrite and we are working on migration documents for users. I also have interest in creating a migration script to automate it for people.

But I don't believe it's fair to Bootstrap as a project to force it to maintain compatibility because it would inconvenience developers who would need to update their sites or come to grips with the changes.


Reply to this email directly or view it on GitHubhttps://github.com//issues/17240#issuecomment-133826150.

@patrickhlauke
Copy link
Member

In my world I cannot inconvenience customers or I do not eat, I lose money when I have to rewrite code

stick with v3, don't upgrade to v4. or am i missing something?

@kkirsche
Copy link
Contributor

Probably important to reiterate the V4 doesn't mean V3 goes away. We'll support it for awhile but it won't stop working and is in my opinion pretty stable overall. I'd just say develop new apps as they come up in V4 and leave existing ones on V3. It won't hurt to not be on the latest and greatest.

@iang0ld
Copy link
Author

iang0ld commented Aug 23, 2015

Yes I think you are.

From: Patrick H. Lauke [mailto:[email protected]]
Sent: Monday, 24 August 2015 12:31 AM
To: twbs/bootstrap [email protected]
Cc: Ian Gold [email protected]
Subject: Re: [bootstrap] Oh no ??!! - We have to start again. Haven't we learn't. (#17240)

In my world I cannot inconvenience customers or I do not eat, I lose money when I have to rewrite code

stick with v3, don't upgrade to v4. or am i missing something?


Reply to this email directly or view it on GitHubhttps://github.com//issues/17240#issuecomment-133851608.

@iang0ld
Copy link
Author

iang0ld commented Aug 23, 2015

Thank you. I totally agree. I appreciate having the opportunity to provide input and food for thought. Only trying to help and raise alternate thoughts.

Keep well.

From: Kevin Kirsche [mailto:[email protected]]
Sent: Monday, 24 August 2015 1:18 AM
To: twbs/bootstrap [email protected]
Cc: Ian Gold [email protected]
Subject: Re: [bootstrap] Oh no ??!! - We have to start again. Haven't we learn't. (#17240)

Probably important to reiterate the V4 doesn't mean V3 goes away. We'll support it for awhile but it won't stop working and is in my opinion pretty stable overall. I'd just say develop new apps as they come up in V4 and leave existing ones on V3. It won't hurt to not be on the latest and greatest.


Reply to this email directly or view it on GitHubhttps://github.com//issues/17240#issuecomment-133859745.

@hnrch02
Copy link
Collaborator

hnrch02 commented Aug 23, 2015

We got rid of some of the annoying and obsolete parts, merged some of the redundant stuff and introduced a few new and exciting things but that's basically housekeeping not "throwing away all the good work the community has done" like you put it - no complete change of course that would make migrating from v3 to v4 next to impossible.

And I think it is absolutely vital for the continued existence of Bootstrap to do that - things need to be changed up every now and then or else the maintainers will start losing interest in it eventually and move on to more interesting projects. Unlike jQuery UI (or Angular or React, for that matter) there's no organization behind Bootstrap that ensures the continued maintenance of the project, we rely on the interest of the maintainers (and not Twitter like some people still seem to think).

And besides, the examples you mentioned - wells and panels - can be easily replicated with cards. Have you looked at our migration guide yet?

@cvrebert cvrebert changed the title Oh no ??!! - We have to start again. Haven't we learn't. Don't break backward compatibility in v4 Aug 23, 2015
@cvrebert
Copy link
Collaborator

Backward compatibility is not free. It incurs a maintenance burden on our small and already overstretched Core Team. It adds bloat, which I guarantee people would gripe about. It makes it impossible for us to fix certain annoying bugs. The whole point of bumping the major version number under SemVer is to allow us to make improvements that require breaking strict backward compatibility.
(Also, at this point, we've already gone too far down this path to be able to make such a drastic course change...)

The only specific features you mentioned ("wells, panels") are among the very easiest for users to migrate away from (to the new Cards widget), so especially in those particular cases, the benefit to adding them back would be relatively low. Thus, I don't think it's worth it to add them back. However, given the relative simplicity of those widgets, it should be pretty easy for yourself or other interested members of the Bootstrap community to create a small v4-compatible add-on library to ease your upgrading process if you find it necessary.

@mdo
Copy link
Member

mdo commented Aug 23, 2015

Yeah, no change here on our major version strategy. We've done it this way for four years and have already committed to breaking (nearly) all the things for our own sanity :).

@mdo mdo closed this as completed Aug 23, 2015
@twbs twbs locked and limited conversation to collaborators Aug 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants