-
-
Notifications
You must be signed in to change notification settings - Fork 79.1k
v4 CSS switch from :before/:after to ::before/::after #17052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm inclined to stay with the single—everyone supports it still and we didn't do the single |
@mdo I'm not sure I agree that it should use single. I'd ask what is the reason for straying from what the actual spec is. In my opinion, it makes more sense to follow the spec and use the correct format than to use a deprecated or legacy format just because it maintains support and some people (arguably) have bad habits on using double colons. This also means that should the project want to use all of the pseudo elements possible it would (potentially) not be able to. The key reason is (emphasis being mine): This |
I'd like to echo @kkirsche for more eloquently voicing my thoughts about the matter. We're unsure how long vendors will support single colon and we know that the spec has been defined to be double--and all major browsers support the spec's syntax now. If anything, a big project like TWBS would teach the 'lazy' folks that they should be using the double colon syntax. I know I personally learned quite a bit about CSS & JS because of this project. It's about setting a good example. |
Ugh fine I guess we'll be responsible then 😁. |
Huzzah! #17058 |
With the drop of IE8 support in v4, it would make sense to use the proper colon-age,
::before, ::after
, to promote best practices since pseudo elements are supposed to have double colons.The text was updated successfully, but these errors were encountered: