Remove helpers from Rails APIs #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this builds off heartcombo#3714 |
|
Can you add testcases? |
| @@ -325,6 +325,9 @@ def self.add_mapping(resource, options) | |||
| mapping = Devise::Mapping.new(resource, options) | |||
| @@mappings[mapping.name] = mapping | |||
| @@default_scope ||= mapping.name | |||
| if defined? Rails and Rails.try(:application).try(:config).try(:api_only) | |||
| @@helpers = [] | |||
There was a problem hiding this comment.
I don't fully understand why this is needed - but by default @@helpers is a Set - so, if it is necessary to clear it, it's probably better to set to Set.new rather than empty array, it may also be better to not call define_helpers if API rather than clearing @@helpers (If that fixes the issue this is needed for)
|
@twalpole: i just updated the commit.
|
|
@twalpole sorry about this. reopening this issue. partially resolved by lynndylanhurley/devise_token_auth#469, but still needs the check on |
|
@djsegal This branch was merged into the official devise master -- you probably want to issue this PR against that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is two changes:
respond_to?(:helper_method))@@helpersfor Rails Api'ssee error below
the reason i need to empty
@@helpersis because I'm usingDeviseTokenAuthand just getting rid ofDevise::Controllers::Helpersinside the codebase would still leave that one helper left (which sparks errors)