-
Notifications
You must be signed in to change notification settings - Fork 413
Create Ruby binding #1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Ruby binding #1032
Conversation
Oh sorry, I intended to create PR for my own repo. |
Hey @kuboon! I am more than happy to have Ruby bindings in the Limbo source tree if that's something you're interested in contributing. The test failure is not related to your PR at all so AFAICT we could just merge this. Let me know what your plans are and feel free to drop by the Limbo developer Discord if you want to chat more. |
bindings/ruby/limbo.gemspec
Outdated
@@ -0,0 +1,18 @@ | |||
Gem::Specification.new do |s| | |||
s.name = "limbo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://rubygems.org/gems/limbo has taken. need to change.
I found The biggest problem is |
} | ||
}, | ||
"onCreateCommand": "pwd; cd bindings/ruby; bundle install" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.devcontainer/bindings-ruby
files are for ruby users (like me) to easily join contributing.
You can add .devcontainer/bindings-python
etc.
https://docs.github.com/en/codespaces/setting-up-your-project-for-codespaces/adding-a-dev-container-configuration/introduction-to-dev-containers#devcontainerjson
if [ ${{ github.event_name }} == "pull_request" ]; then | ||
echo "ruby-versions=[\"3.4\"]" >> $GITHUB_OUTPUT | ||
else | ||
echo "ruby-versions=[\"3.1\",\"3.2\",\"3.3\",\"3.4\"]" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request has been marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs. |
--- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/tursodatabase/limbo?shareId=XXXX-XXXX-XXXX-XXXX).
986c8a4
to
509c8b9
Compare
I've imported latest rust binding and success to get query results. |
@kuboon I have no idea and experience how to interop between Ruby and Rust. But, from the CI it looks like there is some problem in linking some C libraries, at least in the windows test. For Mac, it seems the MacOs version used for linking seems to be older than the one you are targeting? That is what I am understanding from this. This is most likely an error with how |
If we go with the approach of creating a Ruby wrapper for the WASM binding, we can free ourselves from compile gotchas. What do you think? |
This pull request has been marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs. |
This pull request has been closed due to inactivity. Please feel free to reopen it if you have further updates. |
Connection
object from rust to ruby.