feat: add the App Clip's URL to the Run action #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ns-vasilev
force-pushed
the
feature/app-clips
branch
from
f987e8e to
6bb7627
Compare
|
@pepicrft @fortmarek Hi folks! 👋 Would appreciate it if you could take a look at this PR when you have a chance Any feedback or a merge would be greatly appreciated 🙏 |
fortmarek
reviewed
Jun 5, 2025
| @@ -17,6 +17,7 @@ public struct RunAction: Equatable, Codable, Sendable { | |||
| public let metalOptions: MetalOptions? | |||
| public let expandVariableFromTarget: TargetReference? | |||
| public let launchStyle: LaunchStyle | |||
| public let appClipInvocationURLString: String? | |||
There was a problem hiding this comment.
Suggested change
| public let appClipInvocationURLString: String? | |
| public let appClipInvocationURL: URL? |
sorry, this has fallen through the cracks. Feel free to ping us sooner if we forget about something 🙏 |
|
@ns-vasilev what do you think about preparing a PR in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.