Properly parse config, read config from tsconfig.json, set default lib to "es2017" #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BendingBender
force-pushed
the
properly-parse-config
branch
from
a92cfa6 to
90ec133
Compare
BendingBender
force-pushed
the
properly-parse-config
branch
from
90ec133 to
60d93ea
Compare
Closed
…quire('foo')` syntax in test files
This was referenced Mar 25, 2019
sindresorhus
requested changes
Mar 27, 2019
sindresorhus
approved these changes
Mar 27, 2019
SamVerschueren
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes following issues:
package.jsonwas expected to be in the internal TS compiler format (Configtype) contrary to the format that is used intsconfig.json. The config frompackage.jsonwill now be properly parsed.'es2017'lib is now set explicitly which overrides TS default of['dom', 'es6', 'dom.iterable', 'scripthost']. This should flag usages of DOM types without an explicitly specified triple-slash-import (fixes Catch missing lib imports #7).moduleKind: 'commonjs'is now set by default to supportimport foo = require('foo')syntax in test filestsconfig.jsonfile is found it is now used as a config source.skipLibCheck: truecompiler option. This option disables type-checks in *.d.ts files which is the main purpose of this package.