Make numpy a direct dependency of Norfair.
#233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facundo-lezama
force-pushed
the
numpy-dependency
branch
from
74ca5df to
2e8b2eb
Compare
facundo-lezama
force-pushed
the
numpy-dependency
branch
2 times, most recently
from
e1f2f4b to
fd44aef
Compare
facundo-lezama
force-pushed
the
numpy-dependency
branch
from
fd44aef to
5b41ed6
Compare
DiegoFernandezC
approved these changes
Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Norfair uses
numpyin almost every place, butnumpywasn't a direct dependency and was installed when installing other dependencies. With the changes in this PR,numpyis defined as a direct dependency, and versions are determined based on the Python versions.Since no
numpyversion is compatible with both Python3.6and3.10, we needed to be more specific on the version definitions.Also, we updated the
motmetricsversion to1.4.0to handle some issues regarding the newnumpyversion1.24.0.