Added the flag draw_scores to the function draw_boxes. #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore of the class to the tittle on top of the box with the label and id .
javiber
requested changes
Nov 29, 2022
There was a problem hiding this comment.
Thanks for the PR @moooises, just requested a few small changes.
In addition to that, can we add the same option draw_scores to the draw_poinst function? it should behave just like this one.
Again, thank you for the contribution and let me know about if you have any question
norfair/drawing/draw_boxes.py
Outdated
| @@ -182,6 +187,7 @@ def draw_tracked_boxes( | |||
| draw_box: bool = True, | |||
| color_by_label: bool = False, | |||
| draw_labels: bool = False, | |||
| draw_scores: bool = False, | |||
There was a problem hiding this comment.
No need to add this parameter here, this function is deprecated and is just here for backward compatibility
norfair/drawing/utils.py
Outdated
| if draw_scores and drawable.scores is not None: | ||
| if len(text) > 0: | ||
| text += "-" | ||
| text += str(np.round(drawable.scores[0],4)) |
There was a problem hiding this comment.
For bounding boxes, all scores are the same but for keypoints this might not be the case, for this reason, I think is better to draw the average of all scores instead of the first one
|
Ok, I will do it tomorrow. |
…ption to draw_points
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag draw_scores in the function draw_boxes add the score detection of each detected object to a tittle that is drawn on top of the box. Its color and size are the same as the label and the id.