feat(RHOAIENG-21045): Add fairness metrics and tests #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobGeada
requested changes
Apr 2, 2025
| def filter_rows_by_inputs(data, filter_func): | ||
| return data[np.apply_along_axis(filter_func, 1, data)] | ||
|
|
||
| def calculate_confusion_matrix(test: np.array, truth: np.array, positive_class: int) -> dict: |
There was a problem hiding this comment.
| @staticmethod | ||
| def calculate_model( | ||
| samples: np.ndarray, | ||
| model: Any, |
There was a problem hiding this comment.
Do we have a structure/planned datatype for this yet? While I like this idea, I fear it could run into the same security issues as we've been seeing with the explainers in the Java service
tests/metrics/data/data.csv
Outdated
There was a problem hiding this comment.
Are these to test parity against the existing Java service? I wonder if we might want to use synthetically generated data to avoid storing a lot of raw datasets in the repo
christinaexyou
force-pushed
the
add-fairness-metrics
branch
from
49ef199 to
407f057
Compare
christinaexyou
force-pushed
the
add-fairness-metrics
branch
from
b83a31e to
1e28682
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.