Skip to content

chore: enable cgo in driver #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

jctanner
Copy link
Contributor

@jctanner jctanner commented May 12, 2025

Summary by Sourcery

Enable cgo support in the Docker driver image so that the konflux image builds will pass the check-payload tool.

Enhancements:

  • Install necessary system dependencies for cgo in the Docker driver image
  • Set CGO_ENABLED environment variable to true in the Docker build

Copy link

sourcery-ai bot commented May 12, 2025

Reviewer's Guide

This PR updates the Dockerfile.driver to enable cgo support by installing required C toolchains and adjusting build environment variables.

File-Level Changes

Change Details Files
Enable cgo support in the Docker build
  • Install C compiler toolchain (gcc and related packages)
  • Set CGO_ENABLED=1 as an environment variable
  • Add necessary linker flags or dependencies for cgo builds
Dockerfile.driver

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@jctanner jctanner changed the title enable cgo enable cgo in driver May 12, 2025
Copy link

openshift-ci bot commented May 12, 2025

Hi @jctanner. Thanks for your PR.

I'm waiting for a trustyai-explainability member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jctanner - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ruivieira ruivieira added go Pull requests that update Go code ok-to-test labels May 13, 2025
@ruivieira ruivieira moved this to In Review in TrustyAI planning May 13, 2025
@ruivieira ruivieira added this to the ODH 2.29 milestone May 13, 2025
@ruivieira ruivieira self-requested a review May 13, 2025 08:17
@ruivieira
Copy link
Member

@jctanner LGTM. The failing checks are unrelated to the PR and to do with a quay.io outage, AFAIK.

@ruivieira ruivieira changed the title enable cgo in driver chore: enable cgo in driver May 13, 2025
Copy link

@grdryn grdryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jctanner could you bump the FROM images to ubi9 here also as part of this?

@openshift-ci openshift-ci bot added the lgtm label May 13, 2025
Copy link

openshift-ci bot commented May 13, 2025

@jctanner: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/trustyai-service-operator-e2e 4c83b8a link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented May 13, 2025

@grdryn: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: grdryn, ruivieira

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruivieira ruivieira merged commit 13169df into trustyai-explainability:main May 14, 2025
4 of 7 checks passed
@ruivieira ruivieira moved this from In Review to Done in TrustyAI planning May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code lgtm ok-to-test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants