Skip to content

Added s390x support #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

modassarrana89
Copy link
Contributor

Updated build & push to use buildx for multi-arch image i.e. s390x & power.

build & push workflow will be able to generate multi-arch image . Tested the same with local repository

Updated build & push to use buildx for multi-arch image i.e. s390x & power
@modassarrana89
Copy link
Contributor Author

Can someone please review & approved post that

@modassarrana89
Copy link
Contributor Author

modassarrana89 commented Apr 5, 2024

Tested by building multi-arch image by storing at local registry.
Screenshot 2024-04-05 at 15 13 54

@modassarrana89
Copy link
Contributor Author

@danielezonca @RobGeada please review.

Copy link
Member

@danielezonca danielezonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @modassarrana89 for the PR

/lgtm

Copy link

github-actions bot commented Apr 5, 2024

PR image build and manifest generation completed successfully!

📦 PR image: quay.io/trustyai/trustyai-service-operator-ci:ee7410f4dee23e79f65aabda7e2e34dec7668b8e

🗂️ CI manifests

Copy link
Member

@ruivieira ruivieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link

openshift-ci bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danielezonca, ruivieira

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruivieira ruivieira linked an issue Apr 5, 2024 that may be closed by this pull request
Copy link

openshift-ci bot commented Apr 5, 2024

@modassarrana89: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/trustyai-service-operator-e2e ee7410f link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@modassarrana89
Copy link
Contributor Author

modassarrana89 commented Apr 5, 2024

@ruivieira Please merge the change

@ruivieira ruivieira merged commit 9569b40 into trustyai-explainability:main Apr 5, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multi-arch image builds
3 participants