Skip to content

Add tests for CLI flags and checks #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2020
Merged

Add tests for CLI flags and checks #75

merged 2 commits into from
Jul 10, 2020

Conversation

chrisgilmerproj
Copy link

I should have added tests for the CLI flags when I added this code. I found one bug with the AWS account ID by adding these tests. I've also made the test command verbose to help folks see what's being run.

@chrisgilmerproj chrisgilmerproj requested a review from a team July 9, 2020 21:55
@chrisgilmerproj chrisgilmerproj self-assigned this Jul 9, 2020
mdawn
mdawn approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@mdawn mdawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok these make sense to me. I wrote some of these for saber.

always so satisfying to test...cli output /s 😆

@chrisgilmerproj chrisgilmerproj merged commit 53dee1d into master Jul 10, 2020
@chrisgilmerproj chrisgilmerproj deleted the cg_cli_test branch July 10, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdawn mdawn mdawn approved these changes

Assignees

@chrisgilmerproj chrisgilmerproj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisgilmerproj @mdawn