Switch jessevdk/go-flags for spf13/cobra #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary change here is to use spf13/cobra as the CLI backend for this utility, similar to other tools Truss maintains.
This is a breaking change and requires a new release - but a release will not be cut after this PR is merged, more changes are needed.
Additionally:
completion
,help
,version
and puts the original functionality undersetup
subcommand--role
flag to be--iam-role
for clarity--profile
flag to be--aws-profile
for clarityAWS_VAULT_KEYCHAIN_NAME
into a flag named--aws-vault-keychain-name
.logger
for all output instead of the defaultlog
. This will help disambiguate the output from aws-vault golang libs (and other libs) and the logging for this code.Addresses these Pivotal stories: