Skip to content

ci: Enable TF-TRT tests #7424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

ci: Enable TF-TRT tests #7424

wants to merge 4 commits into from

Conversation

pskiran1
Copy link
Member

@pskiran1 pskiran1 commented Jul 8, 2024

Related to PR #7399

What does the PR do?

This PR re-enables the L0_tftrt_optimization and L0_warmup TF-TRT tests that have been disabled since 24.05.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

  • CI Pipeline ID: 16218566

Caveats:

Background

In the 24.05 release, implicit batch support was removed as part of the TRT v10 upgrade. As a result, the TF backend was unable to build TF-TRT engines for implicit batch TF models because it was using implicit batching by default. In the upcoming TF release, the TF backend will use dynamic batching by default, enabling it to successfully build TF-TRT models.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@pskiran1 pskiran1 marked this pull request as ready for review July 8, 2024 17:34
@pskiran1 pskiran1 closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant