Skip to content

L0_model_config Fix #6472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2023
Merged

L0_model_config Fix #6472

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28fa556
Minor fix for CI testing
fpetrini15 Oct 23, 2023
13c9170
Updated statement
fpetrini15 Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qa/L0_model_config/autofill_noplatform/custom/unknown_backend.unknown/expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Invalid argument: unable to find 'libtriton_unknown.so' for model 'unknown_backend.unknown'
Invalid argument: unable to find 'libtriton_unknown.so' or 'unknown/model.py' for model 'unknown_backend.unknown'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: space

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this in reference to the lack of a newline or is there a space issue I am not seeing here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lack of newline. Sorry for being unclear

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! I didn't use a newline because the previous version did not have one and figured the comparison in bash would be sensitive to this change. Taking a closer look in the repo it seems like we are inconsistent in our use of a newline. I know our bash files should end with one. Do we try to apply this principle to all files?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newline check should have fixed this. I think it just doesn't check for this sort of file. I saw the previous file does have an extra line in it but your change deleted that. I think it would be good to change that though (although not a urgent or strong preference)

Copy link
Contributor Author

@fpetrini15 fpetrini15 Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make a note to include this in my next server-based PR that way I don't have to create a new PR and run CI for the newline.