Skip to content

Disable developer tools build for In-process API + JavaCPP tests #6296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 19, 2023
Merged

Disable developer tools build for In-process API + JavaCPP tests #6296

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fa68664
make developer tools test not build for Javacpp-CAPI tests
jbkyang-nvi Sep 12, 2023
74be231
update docs to build dependencies for Javacpp + developer tools
jbkyang-nvi Sep 12, 2023
8b285f3
use client script to build test
jbkyang-nvi Sep 13, 2023
16add5c
modify the documentation
jbkyang-nvi Sep 13, 2023
8927655
updated build script location
jbkyang-nvi Sep 18, 2023
aa7d008
clarified instructions
jbkyang-nvi Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/customization_guide/inference_protocols.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,13 @@ JavaCPP-presets. You can do this using the following steps:

1. Create the JNI binaries in your local repository (`/root/.m2/repository`)
with [`javacpp-presets/tritonserver`](https://github.com/bytedeco/javacpp-presets/tree/master/tritonserver)
For C-API Wrapper Java bindings, you need to install some build specific dependencies like cmake. You can either do this with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For C-API Wrapper Java bindings, you need to install some build specific dependencies like cmake. You can either do this with:
For C-API Wrapper Java bindings, you need to install some build specific dependencies like cmake:

```bash
$ git clone https://github.com/triton-inference-server/developer_tools.git
$ bash -x developer_tools/server/install_dependencies_and_build.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the script lives at this path in the dev tools repo, does it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nvm, I see you moved it in the other PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For C-API Wrapper Java bindings, you need to install some build specific dependencies like cmake. You can either do this with:

Not sure I understand, isn't the C API Java bindings script this one: https://github.com/triton-inference-server/client/blob/main/src/java-api-bindings/scripts/install_dependencies_and_build.sh, not the script in the dev tools repo?

Copy link
Contributor Author

@jbkyang-nvi jbkyang-nvi Sep 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 java bindings, one with CAPI and one with the C++ bindings. The client repo contains the entire build script for C and C++ java . The developer tools repo contains build instructions for C++ bindings. The one in developer tools does not include anything related to java.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But to make it clear I'll just point people to the client script which contains build steps for both versions of the java bindings

```
Please refer to [server installation script](https://github.com/triton-inference-server/client/blob/main/src/java-api-bindings/scripts/install_dependencies_and_build.sh) for dependencies you need to install and modifications you need to make for your container.
After installing dependencies, you can build the tritonserver project on javacpp-presets:
```bash
$ git clone https://github.com/bytedeco/javacpp-presets.git
$ cd javacpp-presets
Expand Down
10 changes: 3 additions & 7 deletions qa/L0_java_memory_growth/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,10 @@

# Set up test files based on installation instructions
# https://github.com/bytedeco/javacpp-presets/blob/master/tritonserver/README.md
set +e
rm -r javacpp-presets
git clone https://github.com/bytedeco/javacpp-presets.git
cd javacpp-presets
mvn clean install --projects .,tritonserver
mvn clean install -f platform --projects ../tritonserver/platform -Djavacpp.platform.host
cd ..
set -e
git clone --single-branch --depth=1 -b ${TRITON_CLIENT_REPO_TAG} https://github.com/triton-inference-server/client.git
source client/src/java-api-bindings/scripts/install_dependencies_and_build.sh -b $PWD --keep-build-dependencies
cd ..

export MAVEN_OPTS="-XX:MaxGCPauseMillis=40"
MODEL_REPO=`pwd`/models
Expand Down
10 changes: 3 additions & 7 deletions qa/L0_java_resnet/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,10 @@ done

# Set up test files based on installation instructions
# https://github.com/bytedeco/javacpp-presets/blob/master/tritonserver/README.md
set +e
rm -r javacpp-presets
git clone https://github.com/bytedeco/javacpp-presets.git
cd javacpp-presets
mvn clean install --projects .,tritonserver
mvn clean install -f platform --projects ../tritonserver/platform -Djavacpp.platform.host
cd ..
set -e
git clone --single-branch --depth=1 -b ${TRITON_CLIENT_REPO_TAG} https://github.com/triton-inference-server/client.git
source client/src/java-api-bindings/scripts/install_dependencies_and_build.sh -b $PWD --keep-build-dependencies
cd ..

CLIENT_LOG="client.log"
SAMPLES_REPO=`pwd`/javacpp-presets/tritonserver/samples/simple
Expand Down
10 changes: 3 additions & 7 deletions qa/L0_java_sequence_batcher/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,10 @@ DATADIR=/data/inferenceserver/${REPO_VERSION}

# Set up test files based on installation instructions
# https://github.com/bytedeco/javacpp-presets/blob/master/tritonserver/README.md
set +e
rm -r javacpp-presets
git clone https://github.com/bytedeco/javacpp-presets.git
cd javacpp-presets
mvn clean install --projects .,tritonserver
mvn clean install -f platform --projects ../tritonserver/platform -Djavacpp.platform.host
cd ..
set -e
git clone --single-branch --depth=1 -b ${TRITON_CLIENT_REPO_TAG} https://github.com/triton-inference-server/client.git
source client/src/java-api-bindings/scripts/install_dependencies_and_build.sh -b $PWD --keep-build-dependencies
cd ..

CLIENT_LOG="client.log"
MODEL_REPO=`pwd`/models
Expand Down
10 changes: 3 additions & 7 deletions qa/L0_java_simple_example/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,10 @@ if [ -z "$REPO_VERSION" ]; then
exit 1
fi

set +e
rm -r javacpp-presets
git clone https://github.com/bytedeco/javacpp-presets.git
cd javacpp-presets
mvn clean install --projects .,tritonserver
mvn clean install -f platform --projects ../tritonserver/platform -Djavacpp.platform.host
cd ..
set -e
git clone --single-branch --depth=1 -b ${TRITON_CLIENT_REPO_TAG} https://github.com/triton-inference-server/client.git
source client/src/java-api-bindings/scripts/install_dependencies_and_build.sh -b $PWD --keep-build-dependencies
cd ..

CLIENT_LOG="client_cpu_only.log"
DATADIR=/data/inferenceserver/${REPO_VERSION}/qa_model_repository
Expand Down