Skip to content

Add MLFlow test for already loaded models (#5658). Update copyright year #5808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy/mlflow-triton-plugin/mlflow_triton/config.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# Copyright 2021-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
Expand Down
2 changes: 1 addition & 1 deletion deploy/mlflow-triton-plugin/mlflow_triton/deployments.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2021-2022, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# Copyright 2021-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
Expand Down
12 changes: 10 additions & 2 deletions qa/L0_mlflow/test.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
# Copyright 2022, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# Copyright 2022-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
Expand Down Expand Up @@ -63,8 +63,12 @@ EOF

rm -rf ./models
mkdir -p ./models
# Put some models in model repository to make sure MLFlow plugin would ignore
# model that is not registered via MLFlow
cp -r ./mlflow-triton-plugin/examples/onnx_float32_int32_int32 ./models/existing_model

SERVER=/opt/tritonserver/bin/tritonserver
SERVER_ARGS="--model-repository=./models --strict-model-config=false --model-control-mode=explicit"
SERVER_ARGS="--model-repository=./models --strict-model-config=false --model-control-mode=explicit --load-model=*"
SERVER_LOG="./inference_server.log"
run_server
if [ "$SERVER_PID" == "0" ]; then
Expand Down Expand Up @@ -102,6 +106,10 @@ if [ $CLI_RET -eq 0 ]; then
echo -e "\n***\n*** Expect deployed 'triton' flavor model to be listed\n***"
CLI_RET=1
fi
if [ `grep -c "existing_model.*READY" $CLI_LOG` != "0" ]; then
echo -e "\n***\n*** Unexpected non-MLflow model listed\n***"
CLI_RET=1
fi
fi
if [ $CLI_RET -eq 0 ]; then
mlflow deployments get -t triton --name onnx_float32_int32_int32 >>$CLI_LOG 2>&1
Expand Down