Skip to content

Give sufficient time to get inference statistics for batcher tests #5699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2023
Merged

Give sufficient time to get inference statistics for batcher tests #5699

merged 2 commits into from
Apr 25, 2023

Conversation

dyastremsky
Copy link
Contributor

L0_batcher occasionally fails with a similar error to that seen in L0_sequence_batcher seen here. Proposing a similar fix to ensure the test does not check statistics before they are ready.

@dyastremsky dyastremsky requested review from rmccorm4 and GuanLuo April 25, 2023 18:02
rmccorm4
rmccorm4 approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we expand this to more tests, we should consider re-using some utility function instead

@dyastremsky dyastremsky merged commit 5d0679a into main Apr 25, 2023
@dyastremsky dyastremsky deleted the dyas-batch-wait branch April 25, 2023 23:51
@dyastremsky dyastremsky mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@GuanLuo GuanLuo Awaiting requested review from GuanLuo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyastremsky @rmccorm4